Handle vendored descriptor.proto gracefully in lowering#710
Merged
emcfarlane merged 9 commits intomainfrom Apr 17, 2026
Merged
Conversation
doriable
approved these changes
Apr 16, 2026
Member
doriable
left a comment
doriable
left a comment
There was a problem hiding this comment.
This looks generally good -- I left a note to include the symbol tables for the test cases, but am fine to approve ahead of those being generated. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #699, which replaced panics with a single valid flag. That flag was too coarse: any missing symbol blocked lowering for every file in the session, so a proto2/proto3 file against a pre-editions vendored descriptor.proto would fail compilation even though it used nothing editions-era.
Changes:
Four fixtures in experimental/ir/testdata/builtins/ cover broken, vendored-proto3 (existing), vendored-proto3 with options, and vendored-editions with unavailable feature.